Register the Moesif consent event publisher#8151
Open
bhagyasakalanka wants to merge 3 commits into
Open
Conversation
Registers the moesifConsentPublisher event handler (module index 71, disabled by default) subscribed to the consent-management events POST_ADD_RECEIPT, POST_AUTHORIZE_CONSENT, POST_REVOKE_RECEIPT and POST_DELETE_RECEIPT, so the Moesif consent publisher can receive them.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe feature configuration closes the existing OAuth token issuance subscriptions array and adds a disabled moesifConsentPublisher scheme with consent and receipt event subscriptions. ChangesConsent Event Publisher Configuration
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8151 +/- ##
============================================
+ Coverage 52.60% 52.91% +0.31%
+ Complexity 21135 20988 -147
============================================
Files 2197 2197
Lines 130930 129659 -1271
Branches 19453 19328 -125
============================================
- Hits 68875 68615 -260
+ Misses 53635 52671 -964
+ Partials 8420 8373 -47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
❌ The last analysis has failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Register the Moesif consent event publisher as an event handler, so it receives the consent-management events. This is the framework-config counterpart to the publisher added in wso2-extensions/identity-moesif-integration#24 — same pattern as the existing Moesif publishers (authentication, flow, registration, org-switch, session, token-issuance).
Change
Adds
moesifConsentPublishertoorg.wso2.carbon.identity.event.server.feature.default.json:module_index71 (next after the token-issuance publisher at 70)properties.enable=false(off by default; enabled per-tenant via the Moesif governance connector)POST_ADD_RECEIPT,POST_AUTHORIZE_CONSENT,POST_REVOKE_RECEIPT,POST_DELETE_RECEIPTThe handler name matches
MoesifConsentDataPublishHandler.getName()(moesifConsentPublisher) in the integration repo.Related